Re: Proposal: Add a callback data parameter to GetNamedDSMSegment

Поиск
Список
Период
Сортировка
От Nathan Bossart
Тема Re: Proposal: Add a callback data parameter to GetNamedDSMSegment
Дата
Msg-id aTyECsCvicaF40iA@nathan
обсуждение исходный текст
Ответ на Re: Proposal: Add a callback data parameter to GetNamedDSMSegment  (Sami Imseih <samimseih@gmail.com>)
Ответы Re: Proposal: Add a callback data parameter to GetNamedDSMSegment
Список pgsql-hackers
On Fri, Dec 12, 2025 at 02:56:39PM -0600, Sami Imseih wrote:
> fair point. In that case why don't we just keep:
> 
> [...]
> -       LWLockInitialize(&dsm->lck, LWLockNewTrancheId("test_dsm_registry"));
> +       LWLockInitialize(&dsm->lck, LWLockNewTrancheId((char *) arg));
>         dsm->val = 0;
> [...]
> 
> instead of creating a new test? For the other GetNamedDSMSegment calls,
> I'll pass NULL to the void * and hard code the tranche name in the init
> callback.

I think we should verify the pointer value more directly.  For example, we
could pass something like (uintptr_t) 0x12345 via the callback argument and
then verify it's the same in the callback.

-- 
nathan



В списке pgsql-hackers по дате отправления: