Re: Proposal: Add a callback data parameter to GetNamedDSMSegment

Поиск
Список
Период
Сортировка
От Nathan Bossart
Тема Re: Proposal: Add a callback data parameter to GetNamedDSMSegment
Дата
Msg-id aTxv6mJtzNYUn1VB@nathan
обсуждение исходный текст
Ответ на Re: Proposal: Add a callback data parameter to GetNamedDSMSegment  (Sami Imseih <samimseih@gmail.com>)
Ответы Re: Proposal: Add a callback data parameter to GetNamedDSMSegment
Список pgsql-hackers
On Fri, Dec 12, 2025 at 12:48:52PM -0600, Sami Imseih wrote:
> As far as testing, I did not think it's worth it since in the cases out
> there now a NULL void * will result in an error when calling
> LWLockNewTrancheId.

I think we should pass NULL to all the existing in-tree calls to
GetNamedDSMSegment(), except for perhaps a new test in test_dsm_registry
that verifies the pointer value in the initialization function.  In all the
other cases, there's no issue with hard-coding the tranche names, so we can
keep those simple.

-- 
nathan



В списке pgsql-hackers по дате отправления: