On Mon, Nov 17, 2025 at 06:45:30PM +0300, Nazir Bilal Yavuz wrote:
> I have two patches to implement this: one moving the killtuples test
> under test/modules/index/, and another adding coverage for the
> recovery path.
>
> 0001 moves killtuples test under the test/modules/index/ without any
> implementation change.
>
> 0002 converts the killtuples isolation test to a TAP test to exercise
> the recovery path. This patch sets up a standby and additionally
> re-inserts into the table while testing the GiST index to ensure
> coverage of the gistRedoDeleteRecord() function.
Hmm. We should try to conclude over the benefit of TAP over
isolation, and merge both patches together if the consensus is towards
a TAP test.
The isolation test feels much cleaner to me in terms of clarity and
debugging output compared to the suggested TAP test as there are many
SQL sequences the test depends on. Other opinions?
--
Michael