Re: compiling pg_bsd_indent

On Thu, Oct  9, 2025 at 11:49:31AM -0400, Andres Freund wrote:
> Hi,
> 
> On 2025-10-09 11:43:57 -0400, Robert Haas wrote:
> > While $SUBJECT today -- using the sources from
> > https://git.postgresql.org/git/pg_bsd_indent.git -- I ran into some
> > problems. I got errors due to the replacement of
> > pg_attribute_noreturn() with pg_return(), and warnings due to variable
> > definitions with no previous extern declaration. Here's a quick and
> > dirty patch.
> 
> I thought we basically only used the in-tree pg_bsd_indent these days?

The last commit in that branch says:

    commit 681a370 (HEAD -> master, origin/master, origin/HEAD)
    Author: Tom Lane <tgl@sss.pgh.pa.us>
    Date:   Sun Apr 23 10:38:15 2023 -0400
    
        Mark this git repo as obsolete.
    
        Add a README note explaining that we've pulled pg_bsd_indent
        into the main Postgres source tree.  This copy will not be
        maintained anymore.

Might be nice if we could just remove it.  It was created by Tom Lane in
2017.

The in-tree ./src/tools/pg_bsd_indent/ doesn't give me any warnings on
gcc 14.2.0.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.