Re: Remove custom redundant full page write description from GIN

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Remove custom redundant full page write description from GIN
Дата
Msg-id aOXzHsq8YYdxZ-RC@paquier.xyz
обсуждение исходный текст
Ответ на Re: Remove custom redundant full page write description from GIN  (Kirill Reshke <reshkekirill@gmail.com>)
Ответы Re: Remove custom redundant full page write description from GIN
Список pgsql-hackers
On Tue, Oct 07, 2025 at 02:08:02PM +0500, Kirill Reshke wrote:
> Turns out we already use XLogRecGetData in assignment:  char *rec =
> XLogRecGetData(record). But I still did alter v2 patch a bit,
> introducing new variable xlrec, to avoid clunky casts between char *
> and ginxlogUpdateMeta.

For UPDATE_META_PAGE, ntuples == 0 could also mean that we may show
a lot of invalid block numbers, as well, which feels a bit pointless.
I have switched that to check InvalidBlockNumber instead.

While reviewing the whole, I have noticed that rightlink was missing
for INSERT_LISTPAGE, as well as the right/left children pages for
SPLIT.  I have added this information, applied the result.  Thanks!
--
Michael

Вложения

В списке pgsql-hackers по дате отправления: