Re: Request to Add New Package: pgsentinel

Hi,

On Wed, Jul 30, 2025 at 04:53:16PM +0200, Christoph Berg wrote:
> Re: Huang Yuying
> > Just wanted to give you a quick update that a new version of pgsentinel has been released with the changes needed
tosupport the Debian build process, as mentioned in the previous email. We’ve also updated the Salsa repo to reflect
thisnew release. 

Thanks for doing this!

> Hi,
>
> thanks for preparing that, everything looks just fine and I already
> built and uploaded the packages.
>
> The repo is now located at https://salsa.debian.org/postgresql/pgsentinel,
> I gave you maintainer access to it.
>
> First bugreport: PG18 doesn't work yet :)

Thanks for the report! ;-)

> 16:45:03 gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels
-Wmissing-format-attribute-Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security
-Wmissing-variable-declarations-fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation
-Wno-stringop-truncation-g -g -O2 -Werror=implicit-function-declaration -fstack-protector-strong
-fstack-clash-protection-Wformat -Werror=format-security -fcf-protection -fno-omit-frame-pointer -g -O2
-Werror=implicit-function-declaration-ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong
-fstack-clash-protection-Wformat -Werror=format-security -fcf-protection -fPIC -fvisibility=hidden -std=c99 -Wall
-Wextra-Werror -Wno-unused-parameter -Wno-implicit-fallthrough -Iinclude -I. -I./ -I/usr/include/postgresql/18/server
-I/usr/include/postgresql/internal   -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2   -c -o
pgsentinel.opgsentinel.c 
> 16:45:03 pgsentinel.c:77:7: error: no previous declaration for ‘pgsentinelDbName’
[-Werror=missing-variable-declarations]
> 16:45:03    77 | char *pgsentinelDbName = "postgres";
> 16:45:03       |       ^~~~~~~~~~~~~~~~
> 16:45:03 cc1: all warnings being treated as errors
>

Just pushed a fix.

Best,
Bertrand