Re: IndexAmRoutine aminsertcleanup function can be NULL?

On Wed, Jul 23, 2025 at 12:07:56PM +0800, Japin Li wrote:
> PFA to assert all required IndexAM callbacks are present.

@@ -42,6 +42,19 @@ GetIndexAmRoutine(Oid amhandler)
         elog(ERROR, "index access method handler function %u did not return an IndexAmRoutine struct",
              amhandler);

+    /* Assert that all required callbacks are present. */
+    Assert(routine->ambuild != NULL);
+    Assert(routine->ambuildempty != NULL);
+    Assert(routine->aminsert != NULL);
+    Assert(routine->ambulkdelete != NULL);
+    Assert(routine->amvacuumcleanup != NULL);
+    Assert(routine->amcostestimate != NULL);
+    Assert(routine->amoptions != NULL);
+    Assert(routine->amvalidate != NULL);
+    Assert(routine->ambeginscan != NULL);
+    Assert(routine->amrescan != NULL);
+    Assert(routine->amendscan != NULL);

Oh.  I like that, and I would like to apply it on HEAD if there are no
objections.
--
Michael