Re: pgsql: Introduce pg_shmem_allocations_numa view

Поиск
Список
Период
Сортировка
От Christoph Berg
Тема Re: pgsql: Introduce pg_shmem_allocations_numa view
Дата
Msg-id aFu6tmQ7EVaaNV9K@msg.df7cb.de
обсуждение исходный текст
Ответ на Re: pgsql: Introduce pg_shmem_allocations_numa view  (Tomas Vondra <tomas@vondra.me>)
Список pgsql-hackers
Re: Bertrand Drouvot
> +/*
> + * Work around Linux kernel bug in 32-bit compat mode: do_pages_stat() has
> + * incorrect pointer arithmetic for more than DO_PAGES_STAT_CHUNK_NR pages.
> + */
> +#if SIZEOF_SIZE_T == 4

I was also missing it in my suggested patch draft, but this should
probably include #ifdef __linux__.


Re: Tomas Vondra
> +#ifdef USE_VALGRIND
> +
> +static inline void
> +pg_numa_touch_mem_if_required(uint64 tmp, char *ptr)

Stupid question, if this function gets properly inlined, why not
always use it as there should be no performance difference vs using a
macro?

Christoph



В списке pgsql-hackers по дате отправления: