Re: pg_upgrade: warn about roles with md5 passwords
От | Nathan Bossart |
---|---|
Тема | Re: pg_upgrade: warn about roles with md5 passwords |
Дата | |
Msg-id | aD4BvIH1SIfJh98P@nathan обсуждение исходный текст |
Ответ на | Re: pg_upgrade: warn about roles with md5 passwords (Jeff Davis <pgsql@j-davis.com>) |
Список | pgsql-hackers |
On Mon, Jun 02, 2025 at 12:41:47PM -0700, Jeff Davis wrote: > On Mon, 2025-06-02 at 12:04 -0500, Nathan Bossart wrote: >> That seems worth considering. Another option could be to just >> document >> that files generated for warnings will be lost without --retain. >> WDYT? > > I haven't looked into it yet, but copying the files to an > "upgrade_warnings" directory sounds like a reasonable way to go. So, right now the upgrade directory will be something like: ./pg_upgrade_output.d/20250602T095620.137 cleanup_output_dirs() recursively deletes everything in the timestamp directory (and the directory itself), and then it cleans up pg_upgrade_output.d if it is empty. My first thought would be to teach cleanup_output_dirs() to delete everything except for files with the ".txt" suffix (so that future warning files are handled, too). This is a little weird because users will be forced to delete the leftover directories and warning files manually, but I'm not sure it's worth adding different --retain modes for that (e.g., --retain=all, --retain=warnings, --retain=none). -- nathan
В списке pgsql-hackers по дате отправления: