Re: Should shared_preload_libraries be loaded during binary upgrade?

On Thu, May 01, 2025 at 10:05:48AM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
>> On Thu, May  1, 2025 at 11:05:56AM +0530, Dilip Kumar wrote:
>>> Does it make sense to load "shared_preload_libraries" during binary
>>> upgrade mode?
> 
>> Well, the library might be required to load the data.  Why would we
>> avoid it with no known error reports?
> 
> You could invent examples that would break things in either direction.
> I'm inclined to leave it alone, because right now the choice is under
> the user's control: she can adjust shared_preload_libraries if needed
> in either the source or target clusters.  If we try to force the
> matter, then one set of problem cases is broken without recourse.
> 
> The lack of field problem reports is another good reason for not
> touching this.

+1, I believe I've seen cases where loading the library was necessary and
others where it breaks the upgrade.  A one-size-fits-all approach probably
won't work here.

-- 
nathan