libpq: Fix wrong connection status on invalid "connect_timeout"

Поиск
Список
Период
Сортировка
Искать
От
Lars Kanis
Тема
libpq: Fix wrong connection status on invalid "connect_timeout"
Дата
Msg-id
a9b4cbd7-4ecb-06b2-ebd7-1739bbff3217@greiz-reinsdorf.de
Список
Дерево обсуждения
libpq: Fix wrong connection status on invalid "connect_timeout" Lars Kanis <lars@greiz-reinsdorf.de>
Re: libpq: Fix wrong connection status on invalid "connect_timeout" Lars Kanis <lars@greiz-reinsdorf.de>
Re: libpq: Fix wrong connection status on invalid "connect_timeout" Michael Paquier <michael@paquier.xyz>
Re: libpq: Fix wrong connection status on invalid "connect_timeout" Lars Kanis <lars@greiz-reinsdorf.de>
Re: libpq: Fix wrong connection status on invalid "connect_timeout" Lars Kanis <lars@greiz-reinsdorf.de>
Re: libpq: Fix wrong connection status on invalid "connect_timeout" Michael Paquier <michael@paquier.xyz>
Re: libpq: Fix wrong connection status on invalid "connect_timeout" Lars Kanis <lars@greiz-reinsdorf.de>
Greetings,

libpq since PostgreSQL-12 has stricter checks for integer values in
connection parameters. They were introduced by commit
https://github.com/postgres/postgres/commit/e7a2217978d9cbb2149bfcb4ef1e45716cfcbefb
.

However in case of "connect_timeout" such an invalid integer value leads
to a connection status other than CONNECTION_OK or CONNECTION_BAD. The
wrong parameter is therefore not properly reported to user space. This
patch fixes this by explicit setting CONNECTION_BAD.

The issue was raised on ruby-pg: https://github.com/ged/ruby-pg/issues/302

It originally came up at Heroku:
https://github.com/heroku/stack-images/issues/147

-- 

Kind Regards,
Lars Kanis

В списке pgsql-hackers по дате отправления
От: Julien Rouhaud
Дата:
От: Lars Kanis
Дата:
FAQ