Re: relcache sometimes initially ignores has_generated_stored

On 2020-01-15 19:11, Andres Freund wrote:
>     /*
>      * Set up constraint/default info
>      */
>     if (has_not_null || ndef > 0 ||
>         attrmiss || relation->rd_rel->relchecks)
> test, i.e. there are no defaults.

> It does still strike me as not great that we can get a different
> relcache entry, even if transient, depending on whether there are other
> reasons to create a TupleConstr. Say a NOT NULL column.
> 
> I'm inclined to think we should just also check has_generated_stored in
> the if quoted above?

Fixed that way.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services