On 23/05/2024 18:36, Srirama Kucherlapati wrote:
> Hi Peter, thanks for your feedback.
>
> We are eager to extend our support in resolving the issues specific
> to AIX or corresponding compilers (XLC and cLang).
>
> But as there are no issues with the patch after reverting the
> changes(with the latest compilers gcc12 and xlc-16.0.1.18), we were
> wondering if this patch can be merged with the current release 17??
>
> Having said that, we are committed to resolve all the hacks and
> caveats that got accumulated specific to AIX over the period by
> picking and resolving one after the other, rather than waiting for
> all the hacks to be fixed.
I'm not eager to put back those hacks just to have them be removed
again. So I'd like to see a minimal patch, with the *minimal* changes
required for AIX support. And perhaps split that into two patches: First
add back AIX support with GCC, and second patch to add XLC support. I'd
like to to see how much of the changes are because of the different
compiler and how much from the OS.
No promises for v17, but if the patch is small and non-intrusive, I
would consider it at least. But let's see what it looks like first. It's
the same work that needs to be done whether it goes into v17 or v18 anyway.
>> One of the reasons that the AIX port ultimately became
>> unmaintainable was that so many hacks and caveats were accumulated
>> over the years. A new port should set a more recent baseline and
>> trim all those hacks.
>
> Please help me understand this, with respect to the AIX specific
> hacks, is it just we can find all the location where _AIX macros are
> involved OR can we just look at the patch changes only, as all the
> changes that were made were specific to AIX. If not, is there any
> other location where we could find all the hacks to be resolved.
>
> Can you provide some more details on the expectations here?
Smallest possible patch that makes Postgres work on AIX again.
Perhaps start with the patch you posted yesterday, but remove hunks from
it one by one, to see which ones are still needed.
--
Heikki Linnakangas
Neon (https://neon.tech)