Re: Building with meson on NixOS/nixpkgs
От | Wolfgang Walther |
---|---|
Тема | Re: Building with meson on NixOS/nixpkgs |
Дата | |
Msg-id | a63ae81b-bb19-4dad-b787-7e5d6414ebfb@technowledgy.de обсуждение исходный текст |
Ответ на | Re: Building with meson on NixOS/nixpkgs ("Tristan Partin" <tristan@partin.io>) |
Список | pgsql-hackers |
Tristan Partin: > On Fri Aug 9, 2024 at 11:14 AM CDT, Andres Freund wrote: > [..] >> commit a00fae9d43e5adabc56e64a4df6d332062666501 >> Author: Heikki Linnakangas <heikki.linnakangas@iki.fi> >> Date: 2024-07-27 13:53:08 +0300 >> >> Fallback to uuid for ossp-uuid with meson >> [..] >> >> I think this is a redundant change with >> >> commit 2416fdb3ee30bdd2810408f93f14d47bff840fea >> Author: Andres Freund <andres@anarazel.de> >> Date: 2024-07-20 13:51:08 -0700 >> >> meson: Add support for detecting ossp-uuid without pkg-config >> [..] > > I'm not sure I would call them redundant. It's cheaper (and better) to > do a pkg-config lookup than it is to do the various checks in your > patch. I think the two patches are complementary. Yours services Windows > plus anywhere else that doesn't have a pkg-config file, while Wolfgang's > services distros that install the pkg-config with a different name. Agreed. There is also a small difference in output for meson: When uuid is queried via pkg-config, meson also detects the version, so I get this output: External libraries [..] uuid : YES 1.6.2 Without pkg-config: External libraries [..] uuid : YES Best, Wolfgang
В списке pgsql-hackers по дате отправления: