Re: gen_guc_tables.pl: Validate required GUC fields before code generation
| От | Peter Eisentraut |
|---|---|
| Тема | Re: gen_guc_tables.pl: Validate required GUC fields before code generation |
| Дата | |
| Msg-id | a6381f56-c8d2-4121-8438-0479aa891419@eisentraut.org обсуждение исходный текст |
| Ответ на | Re: gen_guc_tables.pl: Validate required GUC fields before code generation (Chao Li <li.evan.chao@gmail.com>) |
| Ответы |
Re: gen_guc_tables.pl: Validate required GUC fields before code generation
|
| Список | pgsql-hackers |
I find the data structures that you have constructed here barely
understandable:
my %required_by_type = (
int => [qw(min max)],
real => [qw(min max)],
enum => [qw(options)],
);
for my $f (@required_common, @{ $required_by_type{$entry->{type} //
''} // [] }) {
[qw(min max)] is an array inside an array reference? I think? Do we
need two levels of nesting?
I think this // notation is unnecessarily confusing, and why do we need
two of them. I thought your first patch
+ bool => [], # no extra required fields
+ string => [], # no extra required fields
was clearer. And that way, we also check that the field type is one of
the ones we support.
В списке pgsql-hackers по дате отправления: