Re: [PATCH] Add regression tests of ecpg command notice (error / warning)
От | Fujii Masao |
---|---|
Тема | Re: [PATCH] Add regression tests of ecpg command notice (error / warning) |
Дата | |
Msg-id | a3570706-5c4b-44cf-9c74-0756f41b9e13@oss.nttdata.com обсуждение исходный текст |
Ответ на | Re: [PATCH] Add regression tests of ecpg command notice (error / warning) (Ryo Kanbayashi <kanbayashi.dev@gmail.com>) |
Ответы |
Re: [PATCH] Add regression tests of ecpg command notice (error / warning)
|
Список | pgsql-hackers |
On 2025/03/03 14:09, Ryo Kanbayashi wrote: >> On Mon, Mar 3, 2025 at 12:23 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote: >> On 2025/03/01 19:45, Ryo Kanbayashi wrote: >>>> +program_help_ok('ecpg'); >>>> +program_version_ok('ecpg'); >>>> +program_options_handling_ok('ecpg'); >>>> +command_fails(['ecpg'], 'ecpg without arguments fails'); >>>> >>>> These checks seem unnecessary in 002 since they're already covered in 001. >>> >>> I reflected above. >> >> Thanks for updating the patch! >> >> I've made some minor fixes and cosmetic adjustments. >> The updated patch is attached. >> >> Unless there are any objections, I'll commit it. > > Thanks for reviewing and adustments. > There is no objections :) I've pushed the patch. Thanks! Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION
В списке pgsql-hackers по дате отправления: