On 3/18/20 11:46 PM, Amit Kapila wrote:
> On Thu, Mar 19, 2020 at 3:55 AM Chris Bandy <bandy.chris@gmail.com> wrote:
>>
>>
>> Sorry for these troubles. Attached are patches created using `git
>> format-patch -n -v6` on master at 487e9861d0.
>>
>
> No problem. I have extracted your code changes as a separate patch
> (see attached) as I am not sure we want to add tests for these cases.
Patch looks good.
My last pitch to keep the tests: These would be the first and only
automated tests that verify errtable, errtableconstraint, etc.
> This doesn't apply in back-branches, but I think that is small work
> and we can do that if required.
It looks like the only failing hunk on REL_12_STABLE is in tablecmds.c.
The ereport is near line 5090 there. The partition code has changed
quite a bit compared the older branches. ;-)
Thanks,
Chris