Re: Rework of collation code, extensibility

On Sat, 2022-12-17 at 19:14 -0800, Jeff Davis wrote:
> Attached is a new patch series. I think there are enough changes that
> this has become more of a "rework" of the collation code rather than
> just a refactoring. This is a continuation of some prior work[1][2]
> in
> a new thread given its new scope.

Here's version 5. There are a number of fixes, and better tests, and
it's passing in CI.

The libc hook support is still experimental, but what's working is
passing in CI, even on windows. The challenges with libc hook support
are:

 * It obviously doesn't replace all of libc, so the separation is not
as clean and there are a number of callers throughout the code that
don't necessarily care about specific collations.

 * libc relies on setlocale() / uselocale(), which is global state and
not as easy to track.

 * More platform issues (obviously) and harder to test.

--
Jeff Davis
PostgreSQL Contributor Team - AWS