Re: REPLICA IDENTITY FULL

Поиск
Список
Период
Сортировка
От Peter Eisentraut
Тема Re: REPLICA IDENTITY FULL
Дата
Msg-id a1176974-3263-49bc-3b13-6144529f20ee@2ndquadrant.com
обсуждение исходный текст
Ответ на Re: REPLICA IDENTITY FULL  (Noah Misch <noah@leadboat.com>)
Список pgsql-hackers
On 12/4/17 22:15, Noah Misch wrote:
> While reviewing this patch, I noticed a couple of nearby defects:
> 
> - RelationFindReplTupleSeq() says "Note that this stops on the first matching
>   tuple.", but that's not the case.  It visits every row in the table, and it
>   uses the last match.  The claimed behavior sounds more attractive.

Yeah, that looks like a mistake.

> - RelationFindReplTupleSeq() has comment "/* Start an index scan. */", an
>   inapplicable copy-paste from RelationFindReplTupleByIndex().

I have fixed that.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Jsonb transform for pl/python
Следующее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] static assertions in C++