Re: Making error message more user-friendly with spaces in a URI

On Wed, Nov  6, 2024 at 01:09:12AM +0900, Fujii Masao wrote:
> 
> 
> On 2024/10/31 10:22, Yushi Ogiwara wrote:
> > Hi,
> > 
> > I made a patch to make the error message more user-friendly when using a URI to connect a database with psql.
> > 
> > Current Error Message:
> > 
> > $ psql "postgres://localhost:5432/postgres?application_name=a b"
> > psql: error: trailing data found: "a b"
> > 
> > Currently, if spaces exist in the URI, psql displays this generic error message.
> > 
> > New Error Message (with patch):
> > 
> > psql: error: found unexpected spaces: “a b“. Did you forget to percent-encode spaces?
> > 
> > This revised message is clearer and more concise, guiding users to check for encoding issues.
> 
> I agree the error message could be improved.
> 
> The phrasing "Did you forget" feels a bit indirect to me.
> How about using something clearer and more direct instead?
> 
> -----------
> psql: error: unexpected spaces found "a b", use percent-encoded spaces instead
> -----------

+1

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"