Re: Proposal for Updating CRC32C with AVX-512 Algorithm.

On Thu, Nov 07, 2024 at 11:05:14AM -0500, Andres Freund wrote:
> On 2024-10-30 21:03:20 +0000, Devulapalli, Raghuveer wrote:
>> From a495124ee42cb8f9f206f719b9f2235aff715963 Mon Sep 17 00:00:00 2001
>> From: Nathan Bossart <nathan@postgresql.org>
>> Date: Wed, 16 Oct 2024 15:57:55 -0500
>> Subject: [PATCH v6 5/6] use __attribute__((target(...))) for AVX-512 stuff
> 
> Huh, so now we're undoing a bunch of stuff done earlier. Makes this series
> pretty hard to review.

I'm planning to commit this one very soon (it's being tracked in a separate
thread [0]), so this patch series will need rebasing, anyway.  I think we
should use __attribute__((target(...))) right away for $SUBJECT instead of
undoing stuff in later patches.

[0] https://postgr.es/m/ZywlZzPcPnlqKvt5%40nathan

-- 
nathan