Re: define pg_structiszero(addr, s, r)
| От | Bertrand Drouvot |
|---|---|
| Тема | Re: define pg_structiszero(addr, s, r) |
| Дата | |
| Msg-id | ZySG1uHmmgQT+dpE@ip-10-97-1-34.eu-west-3.compute.internal обсуждение исходный текст |
| Ответ на | Re: define pg_structiszero(addr, s, r) (Peter Eisentraut <peter@eisentraut.org>) |
| Список | pgsql-hackers |
Hi, On Fri, Nov 01, 2024 at 04:36:45PM +0900, Michael Paquier wrote: > On Fri, Nov 01, 2024 at 08:21:50PM +1300, David Rowley wrote: > > My vote is to just revert this usage of the function. Anything more > > elaborate would need to check pointer alignment before using any types > > larger than char. The previous code does not need to do that because > > the page is going to be at least MAXALIGNed. > > Fine, here you go. The attached reverts back this part in bufpage.c > to what it was in 49d6c7d8daba. Thanks! Worth to add a comment as to why pg_memory_is_all_zeros() should not be used here? Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
В списке pgsql-hackers по дате отправления: