Re: Remove dependence on integer wrapping

Поиск
Список
Период
Сортировка
Искать
От
Nathan Bossart
Тема
Re: Remove dependence on integer wrapping
Дата
Msg-id
ZrvUOkL19KHEH2sb@nathan
Ответ на
Список
Дерево обсуждения
Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Tom Lane <tgl@sss.pgh.pa.us>
Re: Remove dependence on integer wrapping Andres Freund <andres@anarazel.de>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Tom Lane <tgl@sss.pgh.pa.us>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Peter Geoghegan <pg@bowt.ie>
Re: Remove dependence on integer wrapping Alexander Lakhin <exclusion@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping jian he <jian.universality@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Matthew Kim <matthewkmkim@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping jian he <jian.universality@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Matthew Kim <matthewkmkim@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping Matthew Kim <matthewkmkim@gmail.com>
Re: Remove dependence on integer wrapping jian he <jian.universality@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping jian he <jian.universality@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Heikki Linnakangas <hlinnaka@iki.fi>
Re: Remove dependence on integer wrapping Matthew Kim <matthewkmkim@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping Alexander Lakhin <exclusion@gmail.com>
Re: Remove dependence on integer wrapping Joseph Koshakow <koshy44@gmail.com>
Re: Remove dependence on integer wrapping Alexander Lakhin <exclusion@gmail.com>
Re: Remove dependence on integer wrapping Nathan Bossart <nathandbossart@gmail.com>
Re: Remove dependence on integer wrapping Tom Lane <tgl@sss.pgh.pa.us>
I've been preparing 0001 for commit.  I've attached what I have so far.

The main changes are the implementations of pg_abs_* and pg_neg_*.  For the
former, I've used abs()/i64abs() for the short/int implementations.  For
the latter, I've tried to use __builtin_sub_overflow() when possible, as
that appears to produce slightly better code.  When
__builtin_sub_overflow() is not available, the values are upcasted before
negation, and we check that result before casting to the return type.  That
approach more closely matches the surrounding functions.  (One exception is
pg_neg_u64_overflow() when we have neither HAVE__BUILTIN_OP_OVERFLOW nor
HAVE_INT128.  In that case, we have to hand-roll everything.)

Thoughts?

-- 
nathan
В списке pgsql-hackers по дате отправления
От: Nathan Bossart
Дата:
От: Tristan Partin
Дата:
FAQ