Re: Harmonizing pg_bsd_indent parameter names
От | Nathan Bossart |
---|---|
Тема | Re: Harmonizing pg_bsd_indent parameter names |
Дата | |
Msg-id | ZmoUBm95xoizU08L@nathan обсуждение исходный текст |
Ответ на | Harmonizing pg_bsd_indent parameter names (Peter Geoghegan <pg@bowt.ie>) |
Ответы |
Re: Harmonizing pg_bsd_indent parameter names
|
Список | pgsql-hackers |
On Wed, Jun 12, 2024 at 05:14:44PM -0400, Peter Geoghegan wrote: > I have been putting this off because I wasn't sure that the policy > should be the same for pg_bsd_indent. Is there any reason to think > that this will create more work down the line? It seems like it might, > due to some kind of need to keep pg_bsd_indent's consistent with > upstream BSD indent. But probably not. The patch is pretty small, in > any case. I would be surprised if this 2-line patch created anything approaching a significant amount of work down the road. FWIW commit 10d34fe already changed one line in indent.c. > I'd like to push this patch now. It's generally easier to be strict > about these inconsistencies. My clang-tidy workflow doesn't > automatically filter out various special cases requiring subjective > judgement, so leaving stuff like this unfixed creates more work down > the road. Are these the only remaining inconsistencies? -- nathan
В списке pgsql-hackers по дате отправления: