Re: [HACKERS] Bogus WAL segments archived after promotion

On Thu, Apr 23, 2015 at 02:57:59PM +0900, Michael Paquier wrote:
> Finally looking at that... The commit log of b2a5545 is a bit
> misleading. Segment files that were recycled during archive recovery
> are not necessarily removed, they could be recycled as well during
> promotion on the new timeline in line with what RemoveOldXlogFiles()
> does. Hence I think that the comment on top of
> RemoveNonParentXlogFiles() should be updated to reflect that like in
> the patch attached.
> 
> Something minor: perhaps we could refactor xlogarchive.c to have
> XLogArchiveCheckDone() and XLogArchiveIsBusy() use the new
> XLogArchiveIsReady().
> Regards,

Old patch, but still valid, so applied to master, thanks.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.