Re: [HACKERS] patch: change magic constants to DEFINE value for readability.

Поиск
Список
Период
Сортировка
От Bruce Momjian
Тема Re: [HACKERS] patch: change magic constants to DEFINE value for readability.
Дата
Msg-id ZWFr188F34d8M7g6@momjian.us
обсуждение исходный текст
Ответ на patch: change magic constants to DEFINE value for readability.  (CharSyam <charsyam@gmail.com>)
Список pgsql-hackers
On Sat, May 23, 2015 at 11:40:36AM +0900, CharSyam wrote:
> in src/backend/utils/misc/tzparser.c
> 
> It uses 60 * 60 to represent SECS_PER_HOUR.
> 
> and It is already define in other files.
> 
> so I think using SECS_PER_HOUR is more clear for readability.
> 
> and I attached patch.(it just change 60 * 60 to SECS_PER_HOUR)
> 
> What do you think?

Yes, this patch is nine years old, but macros are better, as you
suggested, so patch applied to master.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Julien Rouhaud
Дата:
Сообщение: Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements
Следующее
От: John Naylor
Дата:
Сообщение: Re: autovectorize page checksum code included elsewhere