On Tue, Oct 10, 2023 at 02:43:34PM -0400, Robert Haas wrote:
> - I combined what were previously 0002 and 0003 into a single patch,
> since that's how this would get committed.
>
> - I fixed up some comments.
>
> - I updated commit messages.
>
> Hopefully this is getting close to good enough.
I have looked at 0001, for now.. And it looks OK to me.
+ * Nonetheless, this case is simpler than the normal cases handled
+ * above, which must check for changes in doPageWrites and RedoRecPtr.
+ * Those checks are only needed for records that can contain
+ * full-pages images, and an XLOG_SWITCH record never does.
+ Assert(fpw_lsn == InvalidXLogRecPtr);
Right, that's the core reason behind the refactoring. The assertion
is a good idea.
--
Michael