Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
Дата
Msg-id ZSXfiSRfufOnnHwG@paquier.xyz
обсуждение исходный текст
Ответ на Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific  (Evan Jones <evan.jones@datadoghq.com>)
Список pgsql-hackers
On Tue, Oct 10, 2023 at 10:51:10AM -0400, Evan Jones wrote:
> Here is a quick demonstration of this issue, showing that the quoting
> behavior is different between these two. Mac OS X with the "default" locale
> includes quotes because ą includes  0x85 in its UTF-8 encoding:

Ugh.  rowtypes.c has reminded me as well of gistfuncs.c in pageinspect
where included columns are printed in a ROW-like fashion.  And it also
uses isspace() when we check if double quotes are needed or not.  So
the use of the quotes would equally depend on what macos thinks is
a correct space in this case.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: Lowering the default wal_blocksize to 4K
Следующее
От: Andres Freund
Дата:
Сообщение: Re: stopgap fix for signal handling during restore_command