Re: Add support for AT LOCAL

Поиск
Список
Период
Сортировка
Искать
От
Michael Paquier
Тема
Re: Add support for AT LOCAL
Дата
Msg-id
ZS8gha6qJPJADZKe@paquier.xyz
Ответ на
Список
Дерево обсуждения
Add support for AT LOCAL Vik Fearing <vik@postgresfriends.org>
Re: Add support for AT LOCAL Laurenz Albe <laurenz.albe@cybertec.at>
Re: Add support for AT LOCAL Alvaro Herrera <alvherre@alvh.no-ip.org>
Re: Add support for AT LOCAL Vik Fearing <vik@postgresfriends.org>
Re: Add support for AT LOCAL Vik Fearing <vik@postgresfriends.org>
Re: Add support for AT LOCAL Laurenz Albe <laurenz.albe@cybertec.at>
Re: Add support for AT LOCAL Daniel Gustafsson <daniel@yesql.se>
Re: Add support for AT LOCAL Vik Fearing <vik@postgresfriends.org>
Re: Add support for AT LOCAL cary huang <hcary328@gmail.com>
Re: Add support for AT LOCAL Vik Fearing <vik@postgresfriends.org>
Re: Add support for AT LOCAL Michael Paquier <michael@paquier.xyz>
Re: Add support for AT LOCAL Vik Fearing <vik@postgresfriends.org>
Re: Add support for AT LOCAL Michael Paquier <michael@paquier.xyz>
Re: Add support for AT LOCAL Vik Fearing <vik@postgresfriends.org>
Re: Add support for AT LOCAL Michael Paquier <michael@paquier.xyz>
Re: Add support for AT LOCAL Vik Fearing <vik@postgresfriends.org>
Re: Add support for AT LOCAL Michael Paquier <michael@paquier.xyz>
Re: Add support for AT LOCAL Vik Fearing <vik@postgresfriends.org>
Re: Add support for AT LOCAL Michael Paquier <michael@paquier.xyz>
Re: Add support for AT LOCAL Vik Fearing <vik@postgresfriends.org>
Re: Add support for AT LOCAL Michael Paquier <michael@paquier.xyz>
Re: Add support for AT LOCAL Thomas Munro <thomas.munro@gmail.com>
Re: Add support for AT LOCAL Tom Lane <tgl@sss.pgh.pa.us>
Re: Add support for AT LOCAL Thomas Munro <thomas.munro@gmail.com>
Re: Add support for AT LOCAL Tom Lane <tgl@sss.pgh.pa.us>
Re: Add support for AT LOCAL Michael Paquier <michael@paquier.xyz>
Re: Add support for AT LOCAL Thomas Munro <thomas.munro@gmail.com>
Re: Add support for AT LOCAL Michael Paquier <michael@paquier.xyz>
Re: Add support for AT LOCAL Thomas Munro <thomas.munro@gmail.com>
Re: Add support for AT LOCAL Tom Lane <tgl@sss.pgh.pa.us>
Re: Add support for AT LOCAL Thomas Munro <thomas.munro@gmail.com>
Re: Add support for AT LOCAL Tom Lane <tgl@sss.pgh.pa.us>
Re: Add support for AT LOCAL Noah Misch <noah@leadboat.com>
Re: Add support for AT LOCAL Noah Misch <noah@leadboat.com>
Re: Add support for AT LOCAL Tom Lane <tgl@sss.pgh.pa.us>
Re: Add support for AT LOCAL Noah Misch <noah@leadboat.com>
Re: Add support for AT LOCAL Tom Lane <tgl@sss.pgh.pa.us>
Re: Add support for AT LOCAL Michael Paquier <michael@paquier.xyz>
Re: Add support for AT LOCAL Tom Lane <tgl@sss.pgh.pa.us>
Re: Add support for AT LOCAL Tom Lane <tgl@sss.pgh.pa.us>
Re: Add support for AT LOCAL Thomas Munro <thomas.munro@gmail.com>
Re: Add support for AT LOCAL Tom Lane <tgl@sss.pgh.pa.us>
Re: Add support for AT LOCAL Thomas Munro <thomas.munro@gmail.com>
Re: Add support for AT LOCAL Tom Lane <tgl@sss.pgh.pa.us>
Re: Add support for AT LOCAL Robert Haas <robertmhaas@gmail.com>
Re: Add support for AT LOCAL Tom Lane <tgl@sss.pgh.pa.us>
Re: Add support for AT LOCAL Robert Haas <robertmhaas@gmail.com>
Re: Add support for AT LOCAL Tom Lane <tgl@sss.pgh.pa.us>
Re: Add support for AT LOCAL Noah Misch <noah@leadboat.com>
Re: Add support for AT LOCAL Robert Haas <robertmhaas@gmail.com>
Re: Add support for AT LOCAL Andres Freund <andres@anarazel.de>
Re: Add support for AT LOCAL Tom Lane <tgl@sss.pgh.pa.us>
Re: Add support for AT LOCAL Tom Lane <tgl@sss.pgh.pa.us>
Re: Add support for AT LOCAL Tom Lane <tgl@sss.pgh.pa.us>
Re: Add support for AT LOCAL Michael Paquier <michael@paquier.xyz>
Re: Add support for AT LOCAL Michael Paquier <michael@paquier.xyz>
Re: Add support for AT LOCAL Tom Lane <tgl@sss.pgh.pa.us>
Re: Add support for AT LOCAL Michael Paquier <michael@paquier.xyz>
Re: Add support for AT LOCAL Tom Lane <tgl@sss.pgh.pa.us>
Re: Add support for AT LOCAL Michael Paquier <michael@paquier.xyz>
On Tue, Oct 17, 2023 at 12:45:28PM -0400, Tom Lane wrote:
> Whoops, no: for negative starting values we'd need truncate-towards-
> minus-infinity division whereas C99 specifies truncate-towards-zero.
> However, the attached does pass for me on cfarm111 as well as my
> usual dev machine.

I guess that the following trick could be used for the negative case,
with one modulo followed by one extra addition: 
if (result->time < INT64CONST(0))
{
    result->time %= USECS_PER_DAY;
    result->time += USECS_PER_DAY;
}

> Presumably this is a pre-existing bug that also appears in back
> branches.  But in the interests of science I propose that we
> back-patch only the test case and see which machine(s) fail it
> before back-patching the code change.

Sure, as you see fit.
--
Michael
В списке pgsql-hackers по дате отправления
От: Jeff Davis
Дата:
От: Michael Paquier
Дата:
FAQ