Re: [PATCH v1] PQputCopyEnd never returns 0, fix the inaccurate comment

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: [PATCH v1] PQputCopyEnd never returns 0, fix the inaccurate comment
Дата
Msg-id ZO0iS3xhGXL7h+6C@paquier.xyz
обсуждение исходный текст
Ответ на Re: [PATCH v1] PQputCopyEnd never returns 0, fix the inaccurate comment  (Junwang Zhao <zhjwpku@gmail.com>)
Ответы Re: [PATCH v1] PQputCopyEnd never returns 0, fix the inaccurate comment
Список pgsql-hackers
On Mon, Aug 28, 2023 at 09:46:07PM +0800, Junwang Zhao wrote:
> Yeah, it makes sense to me, or maybe just `PQputCopyEnd(...) == -1`,
> let's wait for some other opinions.

One can argue that PQputCopyEnd() returning 0 could be possible in an
older version of libpq these callers are linking to, but this has
never existed from what I can see (just checked down to 8.2 now).
Anyway, changing these callers may create some backpatching conflicts,
so I'd let them as they are, and just fix the comment.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Commitfest manager for September
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Wrong usage of pqMsg_Close message code?