On Fri, Aug 11, 2023 at 08:11:34PM -0400, Tom Lane wrote:
> Hmm. I'm allergic to anything that significantly increases the cost
> of check-world, and this seems like it'd do that.
>
> Maybe we could automate it, but not as part of check-world per se?
It does not have to be part of check-world by default, as we could
make it optional with PG_TEST_EXTRA. I bet that most committers set
this option for most of the test suites anyway, so the extra cost is
OK from here. I don't find a single indent run to be that costly,
especially with parallelism:
$ time ./src/tools/pgindent/pgindent .
real 0m5.039s
user 0m3.403s
sys 0m1.540s
--
Michael