Re: [PATCH] Add loongarch native checksum implementation.

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: [PATCH] Add loongarch native checksum implementation.
Дата
Msg-id ZNTB8S4dwOsWITuk@paquier.xyz
обсуждение исходный текст
Ответ на Re: [PATCH] Add loongarch native checksum implementation.  (Amit Kapila <amit.kapila16@gmail.com>)
Ответы Re: [PATCH] Add loongarch native checksum implementation.  (John Naylor <john.naylor@enterprisedb.com>)
Список pgsql-hackers
On Thu, Aug 10, 2023 at 03:56:37PM +0530, Amit Kapila wrote:
> In MSVC build, on doing: perl mkvcbuild.pl after this commit, I am
> facing the below error:
> Generating configuration headers...
> undefined symbol: USE_LOONGARCH_CRC32C at src/include/pg_config.h line
> 718 at ../postgresql/src/tools/msvc/Mkvcbuild.pm line 872.
>
> Am I missing something or did the commit miss something?

Yes, the commit has missed the addition of USE_LOONGARCH_CRC32C in
Solution.pm.  If you want to be consistent with pg_config.h.in, you
could add it just after USE_LLVM, for instance.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Add assertion on held AddinShmemInitLock in GetNamedLWLockTranche()
Следующее
От: Thomas Munro
Дата:
Сообщение: Re: A failure in 031_recovery_conflict.pl on Debian/s390x