Re: [PATCH] Check more invariants during syscache initialization

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: [PATCH] Check more invariants during syscache initialization
Дата
Msg-id ZMHC6sq7qQSB7Zoz@paquier.xyz
обсуждение исходный текст
Ответ на Re: [PATCH] Check more invariants during syscache initialization  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
Ответы Re: [PATCH] Check more invariants during syscache initialization  (Zhang Mingli <zmlpostgres@gmail.com>)
Список pgsql-hackers
Дерево обсуждения 
On Wed, Jul 26, 2023 at 03:28:55PM +0100, Dagfinn Ilmari Mannsåker wrote:
> Shouldn't these be calling `OidIsValid(…)`, not comparing directly to
> `InvalidOid`?

I think that they should use OidIsValid() on correctness ground, and
that's the style I prefer.  Now, I don't think that these are worth
changing now except if some of the surrounding code is changed for a
different reason.  One reason is that this increases the odds of
conflicts when backpatching on a stable branch.
--
Michael
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Improve pg_stat_statements by making jumble handle savepoint names better
Следующее
От: Peter Smith
Дата:
Сообщение: Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication