Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs
Дата
Msg-id ZKIhpBreDS7OWnfq@paquier.xyz
обсуждение исходный текст
Ответ на Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs  (Daniel Gustafsson <daniel@yesql.se>)
Ответы Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs  (Jacob Champion <jchampion@timescale.com>)
Список pgsql-hackers
Дерево обсуждения 
On Fri, Jun 30, 2023 at 09:42:13AM +0200, Daniel Gustafsson wrote:
> Agreed, I'd prefer all branches to work the same for this.

Thanks, done this way across all the branches, then.

> Reading the patch, only one thing stood out:
>
> -variable PG_TEST_NOCLEAN is set, data directories will be retained
> -regardless of test status.
> +variable PG_TEST_NOCLEAN is set, those directories will be retained
>
> I would've written "the data directories" instead of "those directories" here.

Adjusted that as well, on top of an extra comment.
--
Michael
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Rowley
Дата:
Сообщение: Re: Remove WindowClause PARTITION BY items belonging to redundant pathkeys
Следующее
От: Masahiko Sawada
Дата:
Сообщение: Re: Skip collecting decoded changes of already-aborted transactions