On Mon, Jul 10, 2023 at 07:52:23AM +0200, Drouvot, Bertrand wrote:
> On 7/10/23 7:20 AM, Michael Paquier wrote:
>> Hmm. Something like that could be done, for instance:
>>
>> # src/backend/utils/activity/wait_event_types.h
>> -# typedef enum definitions for wait events.
>> +# typedef enum definitions for wait events, generated from the first
>> +# field.
>
> Yeah, it looks a good place for it.
I am not sure where we are on that based on the objection from Alvaro
to not remove the first column in wait_event_names.txt about
greppability. Anyway, I am not seeing any objections behind my
suggestion to simplify the second column and remove the quotes from
the event names, either. Besides, the suggestion of Andres to improve
the error message on parsing and show the line information is
something useful in itself.
Hence, attached is a rebased patch set that separates the work into
more patches:
- 0001 removes the quotes from the second column, improving the
readability of the .txt file.
- 0002 fixes the report from Andres to improve the error message on
parsing.
- 0003 is the rename of the wait events, in preparation for...
- 0004 that removes entirely the first column (enum element names)
from wait_event_names.txt.
I would like to apply 0001 and 0002 to improve the format if there are
no objections. 0003 and 0004 are still here for discussion, as it
does not seem like a consensus has been reached for that yet. Getting
more opinions would be a good next step for the last two patches, I
assume.
So, any comments?
--
Michael