Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
Дата
Msg-id ZI7BD6jTsn4vdCxe@paquier.xyz
обсуждение исходный текст
Ответ на Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Sun, Jun 18, 2023 at 10:50:16AM +0900, Michael Paquier wrote:
> The difference between scanner_isspace() and array_isspace() is that
> the former matches with what scan.l stores as rules for whitespace
> characters, but the latter works on values.  For hstore, we want the
> latter, with something that works on values.  To keep the change
> locale to hstore, I think that we should just introduce an
> hstore_isspace() which is a copy of array_isspace.  That's a
> duplication, sure, but I think that we may want to think harder about
> \v in the flex scanner, and that's just a few extra lines for
> something that has not changed in 13 years for arrays.  That's also
> easier to think about for stable branches.  If you can send a patch,
> that helps a lot, for sure!

At the end, no need to do that.  I have been able to hack the
attached, that shows the difference of treatment for \v when running
in macOS.  Evan, what do you think?
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
Следующее
От: Jelte Fennema
Дата:
Сообщение: Re: Deleting prepared statements from libpq.