Re: Add LZ4 compression in pg_dump

Поиск
Список
Период
Сортировка
От Justin Pryzby
Тема Re: Add LZ4 compression in pg_dump
Дата
Msg-id ZDdSoaE/30dS+Fxr@telsasoft.com
обсуждение исходный текст
Ответ на Re: Add LZ4 compression in pg_dump  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Add LZ4 compression in pg_dump  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
On Thu, Apr 13, 2023 at 09:37:06AM +0900, Michael Paquier wrote:
> > If you don't insist on calling parse(NONE), the only change is to remove
> > the empty #else, which was my original patch.
> 
> Removing the empty else has as problem to create an empty if block,
> which could be itself a cause of warnings?

I doubt it - in the !HAVE_LIBZ case, it's currently an "if" statement
with nothing but a comment, which isn't a problem.

I think the only issue with an empty "if" is when you have no braces,
like:

    if (...)
#if ...
        something;
#endif

    // problem here //

-- 
Justin



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Thomas Munro
Дата:
Сообщение: Re: Clean up hba.c of code freeing regexps
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Clean up hba.c of code freeing regexps