On Wed, Apr 12, 2023 at 10:07:08AM +0900, Michael Paquier wrote:
> On Tue, Apr 11, 2023 at 07:41:11PM -0500, Justin Pryzby wrote:
> > Maybe I would write it as: "if zlib is unavailable, default to no
> > compression". But I think that's best done in the leading comment, and
> > not inside an empty preprocessor #else.
> >
> > I was hoping Michael would comment on this.
>
> (Sorry for the late reply, somewhat missed that.)
>
> > The placement and phrasing of the comment makes no sense to me.
>
> Yes, this comment gives no value as it stands. I would be tempted to
> follow the suggestion to group the whole code block in a single ifdef,
> including the check, and remove this comment. Like the attached
> perhaps?
+1