On Fri, Mar 03, 2023 at 10:10:15AM +0100, Peter Eisentraut wrote:
> genhtml is part of the lcov package. I think it would be confusing to
> mention it explicitly, since you won't be able to find it as something to
> install. Maybe leave the original list and change "programs" to "packages"?
Makes sense.
> In the installation chapter we use titles like "Building and Installation
> with Autoconf and Make" and "Building and Installation with Meson". We
> should use analogous wordings here.
OK, changed to something like that.
> This ignores which directory you have to be in. The meson calls have to be
> at the top level, the ninja calls have to be in the build directory. We
> should be more precise here, otherwise someone trying this will find that it
> doesn't work.
Hmm. I can see that it is possible to pass the repository to move to
with -C, still it is simpler to move into the build repository.
> Personally I use "meson compile" instead of "ninja"; I'm not sure what the
> best recommendation is, but that least that way all the initial commands are
> "meson something" instead of going back and forth.
Using meson compile is fine by me for the docs. Note that I cannot
see an option with meson to do coverage reports, and my environment
uses 1.0.1. Only ninja handles that.
Updated version attached.
--
Michael