Re: optimize file transfer in pg_upgrade
От | Nathan Bossart |
---|---|
Тема | Re: optimize file transfer in pg_upgrade |
Дата | |
Msg-id | Z9h5Spp76EBygyEL@nathan обсуждение исходный текст |
Ответ на | Re: optimize file transfer in pg_upgrade (Nathan Bossart <nathandbossart@gmail.com>) |
Ответы |
Re: optimize file transfer in pg_upgrade
|
Список | pgsql-hackers |
On Wed, Mar 05, 2025 at 08:34:37PM -0600, Nathan Bossart wrote: > Thank you, Greg and Robert, for sharing your thoughts. With that, here's > what I'm considering to be a reasonably complete patch set for this > feature. This leaves about a month for rigorous testing and editing, so > I'm hopeful it'll be ready v18. Here are my notes after a round of self-review. 0001: * The documentation does not adequately describe the interaction between --no-sync-data-files and --sync-method=syncfs. * I really don't like the exclude_dir hack for skipping the main tablespace directory, but I haven't thought of anything that seems better. * I should verify that there's no path separator issues on Windows for the exclude_dir hack. From some quick code analysis, I think it should work fine, but I probably ought to test it out to be sure. * The documentation needs to mention that the tablespace directories themselves are not synchronized. 0002: * The documentation changes are subject to update based on ongoing stats import/export work. * Does --statistics-only --sequence-data make any sense? It seems like it ought to function as expected, but it's hard to see a use-case. 0003: * Once committed, I should update one of my buildfarm animals to use PG_TEST_PG_UPGRADE_MODE=--swap. * For check_hard_link() and disable_old_cluster(), move the Assert() to an "else" block with a pg_fatal() call for sturdiness. * I need to do a thorough pass-through on all comments. Many are not sufficiently detailed. * The "." and ".." checks in the catalog swap code are redundant and can be removed. * The directory for "moved-aside" stuff should be placed within the old cluster's corresponding tablespace directory so that no changes need to be made to delete_old_cluster.{sh,bat}. * Manual testing with non-default tablespaces! Updated patches based on these notes are attached. -- nathan
Вложения
В списке pgsql-hackers по дате отправления: