Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string

On Tue, Mar 11, 2025 at 03:34:18PM -0700, Masahiko Sawada wrote:
> Pushed.

I'm seeing warnings for the CI build on Windows [0] that appear to be
related to this commit:

    c:\cirrus\contrib\pg_logicalinspect\pg_logicalinspect.c(88) : warning C4715: 'parse_snapshot_filename': not all
controlpaths return a value
 

I suspect we just need to do something like commit fe4ecd0 and return
InvalidXLogRecPtr after the ERROR.

[0] https://api.cirrus-ci.com/v1/task/4876492255002624/logs/build.log

-- 
nathan