On Sat, Sep 24, 2022 at 04:57:51PM -0400, Tom Lane wrote:
> but that isn't great either: it seems redundant and confusing.
> I think we could just make it
>
> errmsg("parameter \"%s\" cannot be set locally in functions",
>
> because that's really the only case users should ever see.
Yes, agreed that "cannot be set locally in functions" should be
enough.
> Other than the message-wording issue, I think v6-0001 is OK.
Just to be sure about something here. The change of behavior with SET
in the context of a PL makes this patch unsuitable for a backpatch,
hence the plan is to apply this stuff only on HEAD, right?
+ <entry><literal>NO_RESET</literal></entry>
+ <entry>Parameters with this flag do not support
+ <command>RESET</command> commands.
+ </entry>
As per the issue with SET commands used with functions, this
description does not completely reflect the reality.
> 0002 seems quite invasive and hard to review compared to what it
> accomplishes. I think we should just keep the flags in the same
> order, stick in GUC_NO_RESET in front of GUC_NO_RESET_ALL, and
> renumber the flag values as needed. I did not change 0002 below,
> though.
0002 is not that confusing to me: the units are moved to be first and
to use the first flag bytes, while the more conceptual flags are moved
to be always after. I would have reorganized a bit more the
description flags, TBH.
--
Michael