On Fri, Sep 16, 2022 at 06:48:36PM -0700, Peter Geoghegan wrote:
> On Fri, Sep 16, 2022 at 6:20 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I'd view the current state of reorderbuffer.h as pretty unacceptable on
>> stylistic grounds no matter which position you take. Having successive
>> declarations randomly using named or unnamed parameters is seriously
>> ugly and distracting, at least to my eye. We don't need such blatant
>> reminders of how many cooks have stirred this broth.
>
> I'll come up with a revision that deals with that too, then. Shouldn't
> be too much more work.
Being able to catch unnamed paramaters in function declarations would
be really nice. Thanks for looking at that.
> I suppose that I ought to backpatch a fix for the really egregious
> issue in hba.h, and leave it at that on stable branches.
If check_usermap() is used in a bugfix, that could be a risk, so this
bit warrants a backpatch in my opinion.
--
Michael