On Fri, Jul 8, 2022 at 10:55:55PM -0400, Bruce Momjian wrote:
> > The/that inconsistency ... choose one. Or actually, the "an ... the"
> > combination you used elsewhere doesn't grate on the ear either.
> >
> > + For each extension, refuse to drop anything if any objects (other than the
> > + extensions listed) depend on it. However, its own member objects, and routines
> > + that are explicitly dependent on this extension, are skipped.
> > + This is the default.
> >
> > "skipped" seems like a horrible choice of word; it could easily be read as
> > "they don't get dropped". I am not convinced that mentioning the member
> > objects here is an improvement either. In the first sentence you are
> > treating each extension as a monolithic object; why not in the second?
>
> I created a modified patch based on this feedback; patch attached. I
> rewrote the last change.
Patch applied to PG 13 and later, where extension dependency was added.
Thank you for the patch.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Indecision is a decision. Inaction is an action. Mark Batterson