Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.
Дата
Msg-id Ys53oZ75RF3RxKb0@paquier.xyz
обсуждение исходный текст
Ответ на Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.  (vignesh C <vignesh21@gmail.com>)
Ответы Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.  (Peter Smith <smithpb2250@gmail.com>)
Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.  (vignesh C <vignesh21@gmail.com>)
Список pgsql-hackers
On Wed, Jul 13, 2022 at 12:22:06PM +0530, vignesh C wrote:
> Most of the code is common between GetSubscriptionRelations and
> GetSubscriptionNotReadyRelations. Added a parameter to
> GetSubscriptionRelations which could provide the same functionality as
> the existing GetSubscriptionRelations and
> GetSubscriptionNotReadyRelations. Attached patch has the changes for
> the same. Thoughts?

Right.  Using all_rels to mean that we'd filter relations that are not
ready is a bit confusing, though.  Perhaps this could use a bitmask as
argument.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kyotaro Horiguchi
Дата:
Сообщение: make update-po@master stops at pg_upgrade
Следующее
От: Peter Smith
Дата:
Сообщение: Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.