Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa

Поиск
Список
Период
Сортировка
Искать
От
Michael Paquier
Тема
Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa
Дата
в 00:13:48
Msg-id
YnW5vFw4tBqX6yRA@paquier.xyz
Ответ на
Список
Дерево обсуждения
pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa Michael Paquier <michael@paquier.xyz>
Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa Andrew Dunstan <andrew@dunslane.net>
Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa Michael Paquier <michael@paquier.xyz>
Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa Andrew Dunstan <andrew@dunslane.net>
Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa Michael Paquier <michael@paquier.xyz>
Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa Andrew Dunstan <andrew@dunslane.net>
Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa Michael Paquier <michael@paquier.xyz>
Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa Michael Paquier <michael@paquier.xyz>
Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa Andrew Dunstan <andrew@dunslane.net>
Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa Michael Paquier <michael@paquier.xyz>
Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa Michael Paquier <michael@paquier.xyz>
On Fri, May 06, 2022 at 10:12:36AM -0400, Andrew Dunstan wrote:
> On 2022-05-02 Mo 03:06, Michael Paquier wrote:
> vcpkg doesn't install any.exe files AFAICS, just DLLs, headers, .lib
> files etc.

Okay, thanks for confirming.

>>> I don't think we should do that check for every time we call
>>> vc_regress.pl, that seems wasteful. Maybe do it if the command is one
>>> that might require these commands, which I think would be bincheck or
>>> taptest. And/Or stash some status somewhere?
>>
>> Mostly.  We also care about gzip in contrib/basebackup_to_shell/,
>> though contribcheck does not run the TAP tests of contrib/ modules.
>> As you say, setting up those variables in bincheck and taptest would
>> be enough.
> 
> That would be a start. Maybe meson will us get rid of some of this mess ...

Let's do that for now then as we need a middle ground for HEAD.  I'll
come up with something at the beginning of next week.
--
Michael
В списке pgsql-committers по дате отправления
От: Andres Freund
Дата:
От: Thomas Munro
Дата:
FAQ