On Tue, Oct 19, 2021 at 02:40:04PM +0000, Bossart, Nathan wrote:
> On 10/18/21, 11:49 PM, "Matthijs van der Vleuten" <postgresql@zr40.nl> wrote:
>> The test case doesn't seem entirely correct to me? The index being
>> dropped (btree_tall_tbl_idx2) doesn't exist.
>
> This was fixed before it was committed [0].
Yes, my apologies about this brain fade. The committed code is
hopefully fine :)
>> Also, I don't believe this tests the case of dropping the index when
>> it previously has been altered in this way.
>
> That can still fail with the "has no options" ERROR, and fixing it
> will still require a manual catalog update. The ERROR is actually
> coming from the call to index_open(), so bypassing it might require
> some rather intrusive changes. Given that it took over a year for
> this bug to be reported, I suspect it might be more trouble than it's
> worth.
This may need a mention in the release notes, but the problem is I
guess not that spread enough to worry or people would have complained
more since 13 was out. Logical dumps discard that automatically and
even for the ANALYZE case, the pre-committed code would have just
ignored the reloptions retrieved by get_attribute_options().
--
Michael