Re: INT64_FORMAT in translatable strings

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: INT64_FORMAT in translatable strings
Дата
Msg-id YIFUs9vWoI4IOKIn@paquier.xyz
обсуждение исходный текст
Ответ на INT64_FORMAT in translatable strings  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Список pgsql-hackers
On Wed, Apr 21, 2021 at 08:00:00PM +0900, Kyotaro Horiguchi wrote:
> Anyway we can rely on %lld/%llu and we decided to use them in
> translatable strings.  So the attached fixes (AFAICS) all instances of
> the macros in translatable strings.

Indeed, good catch.  Thanks.

> # I just found 3286065651 did one instance of that so I excluded that
> # from this patch.

May I ask why you are using "unsigned long long int" rather uint64?
What you are proposing is more consistent with what's done in the
signed case like 3286065, so no objections from me, but I was just
wondering.  Personally, I think that I would just use "unsigned long
long", like in xlogreader.c or pg_controldata.c to take two examples.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Langote
Дата:
Сообщение: Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: Replication slot stats misgivings