Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows

Поиск
Список
Период
Сортировка
Искать
От
Michael Paquier
Тема
Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows
Дата
Msg-id
YHrc24AgJQ6tQ1q0@paquier.xyz
Ответ на
Список
Дерево обсуждения
File truncation within PostgresNode::issues_sql_like() wrong on Windows Michael Paquier <michael@paquier.xyz>
Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows Andrew Dunstan <andrew@dunslane.net>
Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows Michael Paquier <michael@paquier.xyz>
Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows Andrew Dunstan <andrew@dunslane.net>
Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows Michael Paquier <michael@paquier.xyz>
Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows Andrew Dunstan <andrew@dunslane.net>
Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows Michael Paquier <michael@paquier.xyz>
Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows Andrew Dunstan <andrew@dunslane.net>
Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows Michael Paquier <michael@paquier.xyz>
Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows Andrew Dunstan <andrew@dunslane.net>
Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows Michael Paquier <michael@paquier.xyz>
On Thu, Apr 15, 2021 at 09:12:52PM -0400, Andrew Dunstan wrote:
> It's worked on fairywren, I will double check on drongo and if all is
> well will commit.

Thanks Andrew.  For the archive's sake, this has been committed as of
3c5b068.

While reading the commit, I have noticed that you used SEEK_SET
instead of 0 as I did in my own patch.  That makes the code easier to
understand.  Could it be better to apply the same style to all the
perl scripts doing some seek() calls?  Please see the attached.
--
Michael
В списке pgsql-hackers по дате отправления
От: Esteban Zimanyi
Дата:
От: Amit Kapila
Дата:
FAQ