Re: [PATCH] random_normal function

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: [PATCH] random_normal function
Дата
Msg-id Y5K5p0UrxCqv/OhO@paquier.xyz
обсуждение исходный текст
Ответ на Re: [PATCH] random_normal function  (Paul Ramsey <pramsey@cleverelephant.ca>)
Ответы Re: [PATCH] random_normal function  (Paul Ramsey <pramsey@cleverelephant.ca>)
Список pgsql-hackers
On Thu, Dec 08, 2022 at 04:44:56PM -0800, Paul Ramsey wrote:
> Final tme, with fixes from cirrusci.

Well, why not.  Seems like you would use that a lot with PostGIS.

 #include <math.h>              /* for ldexp() */
+#include <float.h>             /* for DBL_EPSILON */
And be careful with the order here.

+static void
+drandom_check_default_seed()
We always use (void) rather than empty parenthesis sets.

I would not leave that unchecked, so I think that you should add
something in ramdom.sql.  Or would you prefer switching some of
the regression tests be switched so as they use the new normal
function?

(Ahem.  Bonus points for a random_string() returning a bytea, based on
pg_strong_random().)
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Allow tests to pass in OpenSSL FIPS mode
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: add \dpS to psql